London | 26-ITP-January | Laura C | Sprint 1 | Wireframe to Web Code#963
London | 26-ITP-January | Laura C | Sprint 1 | Wireframe to Web Code#963lauracs24 wants to merge 4 commits intoCodeYourFuture:mainfrom
Conversation
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Good job on the short and straight-forward answers. By your definitions of git branch, it might be confusing for a beginner. This is a good reference: Git branch |
|
Hi @JaypeeLan, sorry, should I rewrite the definition? I can see that the pull request is not 'complete' yet. |
|
Yes you can read up the definition on W3 schools. It gives better insight and clear explanation. Then make a commit so I can update the label. |
|
Hi @JaypeeLan, I updated the definition to be clearer for beginners and added the W3Schools link. Thanks! |
|
Hi @JaypeeLan let me know if you need anything else |
|
Please let me know if either of you can review this request, as I would like to submit my module 1 onboarding soon. Thank you! |
|
@lauracs24 Can you address these:
|
|
Hi @cjyuan, thank you so much for looking at my code! I fixed the HTML validation warning by adding a heading to the section. I also confirmed there are no remaining validator errors. Let me know if this is enough |
|
Changes looks great. It looks like the "Changelist" header in the PR description is not yet properly formatted in Markdown syntax. Changelistinstead of like this May I suggest reading this article when you have time? |
|
Ah I see, apologies for that! hopefully its better now |

London | 26-ITP-January | Laura C | Sprint 1 | Wireframe to Web Code
Self checklist
Changelist
I created a webpage based on the provided wireframe explaining README files, wireframes, and Git branches.
The page uses semantic HTML, is styled with CSS, and passes Lighthouse accessibility checks.